Skip to content

Blacklist mysqli tests from skip cache #6726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

MaxSem
Copy link
Contributor

@MaxSem MaxSem commented Feb 24, 2021

See #6681 for discussion.

@nikic
Copy link
Member

nikic commented Mar 1, 2021

We need to find a more permanent solution for this. This could take one of two forms: We say that what mysqli is currently doing is incorrect, and it can't rely on skipif being run before the test. This seems a bit annoying for these tests, because code would have to be duplicated between the skipif and the test. The alternative is to have an opt-out for caching. For example, we could print a nocache result from skipif.

@nikic
Copy link
Member

nikic commented Mar 4, 2021

I've implemented the nocache tag in 4d43cbe and 0074a1d, so this should hopefully be resolved now.

@nikic nikic closed this Mar 4, 2021
@MaxSem MaxSem deleted the mysqli-plug branch March 6, 2021 20:02
@MaxSem
Copy link
Contributor Author

MaxSem commented Mar 6, 2021

Thanks, Nikita.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants